Add missing Migration parameter update and a fix for boxes where the migration has already taken place without the update.

BulkPrinting/BulkPrinting/Migrations.cs

@@ -132,6 +132,8 @@ namespace BulkPrinting
                 db,
                 "ALTER TABLE Orders ADD COLUMN InternalReference VARCHAR(32)",
                 "ALTER TABLE Batch ADD COLUMN InternalReference VARCHAR(32)",
+
+                // IMPORTANT
                 "INSERT INTO Parameters (Key, Value) VALUES ('Migration','1')"
             );
         }
@@ -150,7 +152,6 @@ namespace BulkPrinting
                 "CREATE UNIQUE INDEX Parameters_Key ON Parameters(Key)",
                 "CREATE INDEX Orders_OrderDate ON Orders(OrderDate)",
                 "CREATE INDEX OrderedItems_OrderId ON OrderedItems(OrderId)",
-                "UPDATE Parameters SET Value='2' WHERE Key='Migration'",
                 "UPDATE Batch SET Downloaded=(ReadyForDownload=1 AND DeliveredQuantity<=COALESCE((SELECT COUNT(*) FROM Voucher WHERE Voucher.BatchId=Batch.Id), 0))",
                 "INSERT INTO Parameters (Key, Value) VALUES ('LastSyncedBatchId', '0')",
                 "INSERT INTO Parameters (Key, Value) VALUES ('SyncBackwardsFromLogId', '0')",
@@ -165,7 +166,10 @@ namespace BulkPrinting
                 "INSERT INTO Logs_New (Id, UserId, VoucherId, EventDate, EventType, Retry) " +
                     "SELECT Id, UserId, VoucherId, EventDate, EventType, Retry FROM Logs",
                 "DROP TABLE Logs",
-                "ALTER TABLE Logs_New RENAME TO Logs"
+                "ALTER TABLE Logs_New RENAME TO Logs",
+
+                // IMPORTANT
+                "UPDATE Parameters SET Value='2' WHERE Key='Migration'"
             );
         }
 
@@ -173,8 +177,13 @@ namespace BulkPrinting
         {
             return ApplyMigrationQueries(
                 db,
-                "CREATE INDEX Logs_VoucherId_EventType_Id ON Logs(VoucherId, EventType, Id)"
-            );
+
+                // Forgot to update the migration value initially, hence the 'NOT EXISTS'
+                "CREATE INDEX IF NOT EXISTS Logs_VoucherId_EventType_Id ON Logs(VoucherId, EventType, Id)",
+
+                // IMPORTANT
+                "UPDATE Parameters SET Value='3' WHERE Key='Migration'"
+           );
         }
     }
 }