Add JSON error format handling.

Fix for failures during batch ordering.

BulkPrinting/BulkPrinting/Models.cs

@@ -25,6 +25,15 @@ namespace BulkPrinting
         Online = 2
     }
 
+    public class MaxException
+    {
+        [JsonProperty("code")]
+        public int? Code { get; set; }
+
+        [JsonProperty("error")]
+        public string Error { get; set; }
+    }
+
 
     public class LoginData
     {

BulkPrinting/BulkPrinting/OrderForm.cs

@@ -165,6 +165,14 @@ namespace BulkPrinting
                         OrderData.InternalReference = InternalReference;
                         BatchListing OrderedBatch = new BatchListing();
                         bool OrderResult = Utility.RESTRequest<OrderPlacementData, BatchListing>(OrderData, ref OrderedBatch, "/api/batches/");
+                        if (OrderedBatch.Batch == null) {
+                            string ErrorMessage = "An error occurred while attempting to order " + OrderedItem.Quantity.ToString() + " of " + OrderedItem.ProductDescription;
+                            if (i < (SelectedProducts.Count - 1)){
+                                ErrorMessage += "\nPress OK to continue attempting to order remaining items.";
+                            }
+                            MessageBox.Show(ErrorMessage ,"Error Ordering",MessageBoxButtons.OK,MessageBoxIcon.Error);
+                            continue;
+                        }
                         //TODO: Handle failed order
                         Utility.DownloadBatch(OrderedBatch.Batch);
                         Globals.SessionData.Credentials.Payload.User.Account.Balance = OrderedBatch.RemainingBalance;

BulkPrinting/BulkPrinting/UserLoginForm.cs

@@ -131,10 +131,6 @@ namespace BulkPrinting
                         Utility.SyncLogs(); //Perform log sync before any logging happens to ensure synchronicity with server
                     }
                 }
-                else
-                {
-                    MessageBox.Show("The login attempt failed. Please try again.", "Login Failed", MessageBoxButtons.OK, MessageBoxIcon.Error);
-                }
             }
             if (LoginSuccessful == true)
             {

BulkPrinting/BulkPrinting/Utility.cs

@@ -92,7 +92,24 @@ namespace BulkPrinting
 
                 return true;
             }
-            catch (WebException) {
+            catch (WebException ex)
+            {
+                if (ex != null && ex.Response != null)
+                {
+                    var response = ex.Response;
+                    var stream = response.GetResponseStream();
+                    var reader = new StreamReader(stream);
+                    var message = reader.ReadToEnd();
+                    MaxException MaxError = JsonConvert.DeserializeObject<MaxException>(message);
+                    if (MaxError.Code != null)
+                    {
+                        MessageBox.Show("Error " + MaxError.Code.ToString() + ": " + MaxError.Error, "Login Failed", MessageBoxButtons.OK, MessageBoxIcon.Error);
+                    }
+                    else
+                    {
+                        MessageBox.Show("Login Failed. Please try again.", "Login Failed", MessageBoxButtons.OK, MessageBoxIcon.Error);
+                    }
+                }
                 return false;
             }
         }
@@ -135,45 +152,23 @@ namespace BulkPrinting
                 Result = JsonConvert.DeserializeObject<R>(responseString);
                 return true;
             }
-            catch (WebException)
+            catch (WebException ex)
             {
+                if (ex != null && ex.Response != null)
+                {
+                    var response = ex.Response;
+                    var stream = response.GetResponseStream();
+                    var reader = new StreamReader(stream);
+                    var message = reader.ReadToEnd();
+                    MaxException MaxError = JsonConvert.DeserializeObject<MaxException>(message);
+                    if (MaxError.Code != null)
+                    {
+                        MessageBox.Show("Error " + MaxError.Code.ToString() + ": " + MaxError.Error, "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
+                    }
+                }
                 return false;
             }
         }
-        /*
-        private static bool RegSave(string Key, string Value)
-        {
-            bool Result;
-            try
-            {
-                RegistryKey MaxRegistry = Registry.CurrentUser.OpenSubKey("Software\\M@X\\BulkPrint");
-                Registry.SetValue(MaxRegistry.Name, Key, Value);
-                Registry.CurrentUser.Close();
-                Result = true;
-            }
-            catch (Exception)
-            {
-                Result = false;
-            }
-            return Result;
-        }
-
-        public static string RegFetch(string Key)
-        {
-            string Result;
-            try
-            {
-                RegistryKey MaxRegistry = Registry.CurrentUser.OpenSubKey("Software\\M@X\\BulkPrint");
-                Result = Registry.GetValue(MaxRegistry.Name, Key, "").ToString();
-                Registry.CurrentUser.Close();
-            }
-            catch (Exception)
-            {
-                Result = "";
-            }
-            return Result;
-        }
-        */
 
         private static bool SaveSetting(string Key, string Value)
         {