Optimised check for unprinted vouchers in range on Reprint next button

Changed printing to send one large job instead of one job per row

BulkPrinting/BulkPrinting/ReprintForm.cs

@@ -113,8 +113,17 @@ namespace BulkPrinting
 
             VoucherCount = SelectedRangeEnd - SelectedRangeStart + 1;
             decimal VoucherFaceValue = (decimal)Command.ExecuteScalar();
-            int UnprintedVouchersInRange = Utility.GetNumberOfUnprintedVouchersInRange((int)numFirstSeqNum.Value, (int)numLastSeqNum.Value, BatchID);
 
+            string countsql = "SELECT COUNT(v.ID) FROM Voucher v LEFT JOIN Logs l ON v.Id=l.VoucherId AND l.EventType=@event WHERE v.BatchId=@batchid AND v.SequenceNumber BETWEEN @startseq AND @endseq AND l.id IS NULL";
+            SQLiteCommand NewCommand = new SQLiteCommand(countsql, Globals.DBConnection);
+
+            NewCommand.Parameters.AddWithValue("@event", (int) VendorEvent.VendorEventType.PrintVoucher);
+            NewCommand.Parameters.AddWithValue("@batchid", BatchID);
+            NewCommand.Parameters.AddWithValue("@startseq", SelectedRangeStart);
+            NewCommand.Parameters.AddWithValue("@endseq", SelectedRangeEnd);
+
+            var result = Command.ExecuteScalar();//Utility.GetNumberOfUnprintedVouchersInRange((int)numFirstSeqNum.Value, (int)numLastSeqNum.Value, BatchID);
+            int UnprintedVouchersInRange = int.Parse(result.ToString());
             decimal PrintedVoucherValue = (VoucherCount - UnprintedVouchersInRange) * VoucherFaceValue;
             decimal UnprintedVoucherValue = UnprintedVouchersInRange * VoucherFaceValue;
 

BulkPrinting/BulkPrinting/Utility.cs

@@ -422,6 +422,8 @@ namespace BulkPrinting
 
             using (SQLiteDataReader read = Command.ExecuteReader())
             {
+                int JobID = Globals.MaxPrinter.Open("Vouchers");
+                if (JobID == 0) return;
                 while (read.Read())
                 {
                     VoucherCount++;
@@ -475,10 +477,7 @@ namespace BulkPrinting
                             PrintRow += (Column == 2 ? " " : "") + IndividualVoucher.Description.PadRight(30, ' ');
                         }
                         PrintRow = PrintRow.TrimEnd() + "\r\n\n\n\n\n\n\n\n\n\n\n";
-                        int JobID = Globals.MaxPrinter.Open("Vouchers");
-                        if (JobID == 0) return;
                         Globals.MaxPrinter.Print(PrintRow);
-                        Globals.MaxPrinter.Close();
                         foreach (PrintVoucher PrintedVoucher in VoucherRow)
                         {
                             var ExportEvent = new EventLog();
@@ -499,6 +498,7 @@ namespace BulkPrinting
                     }
                     TotalCount++;
                 }
+                Globals.MaxPrinter.Close();
             }
             Utility.LogBulkEvents(LogEvents);
         }