Move hardcoded FTP settings into the configuration.

BulkPrintingAPI/Configuration/FTPOptions.cs

@@ -0,0 +1,18 @@
+using Microsoft.Extensions.Configuration;
+
+namespace BulkPrintingAPI.Configuration
+{
+    public class FTPOptions
+    {
+        public FTPOptions(IConfiguration configuration)
+        {
+            configuration.Bind(this);
+        }
+
+        public string Host { get; set; }
+
+        public string Username { get; set; }
+
+        public string Password { get; set; }
+    }
+}

BulkPrintingAPI/Controllers/BatchesController.cs

@@ -33,16 +33,18 @@ namespace BulkPrintingAPI.Controllers
         private readonly ILogger _logger;
         private readonly IMemoryCache _cache;
         private readonly DataEncryptionOptions _dataEncryptionOptions;
+        private readonly FTPOptions _ftpOptions;
         private readonly MAX.ClientFactory _clientFactory;
         private readonly MAXContext _context;
 
         public BatchesController(ILoggerFactory loggerFactory, IMemoryCache cache,
-            DataEncryptionOptions dataEncryptionOptions,
+            DataEncryptionOptions dataEncryptionOptions, FTPOptions ftpOptions,
             MAX.ClientFactory clientFactory, MAXContext context)
         {
             _logger = loggerFactory.CreateLogger(GetType().FullName);
             _cache = cache;
             _dataEncryptionOptions = dataEncryptionOptions;
+            _ftpOptions = ftpOptions;
             _clientFactory = clientFactory;
             _context = context;
         }
@@ -82,7 +84,7 @@ namespace BulkPrintingAPI.Controllers
 
             if (!batch.ReadyForDownload)
             {
-                await Utils.DownloadVouchersAsync(_context, batch);
+                await Utils.DownloadVouchersAsync(_ftpOptions, _context, batch);
             }
 
             return Ok(batch);
@@ -117,7 +119,7 @@ namespace BulkPrintingAPI.Controllers
 
             try
             {
-                await Utils.DownloadVouchersAsync(_context, orderResponse.Batch);
+                await Utils.DownloadVouchersAsync(_ftpOptions, _context, orderResponse.Batch);
             }
             catch (Exception e)
             {

BulkPrintingAPI/Controllers/Utils.cs

@@ -302,16 +302,17 @@ namespace BulkPrintingAPI.Controllers
             }
         }
 
-        public static async Task DownloadVouchersAsync(MAXContext context, Batch batch)
+        public static async Task DownloadVouchersAsync(FTPOptions ftpOptions, MAXContext context,
+            Batch batch)
         {
             var remoteFileName = string.Format("{0}_{1}.dat", batch.Account.Id, batch.Id);
             using (var voucherStream = new MemoryStream())
             {
                 using (var ftp = new FtpClient(new FtpClientConfiguration()
                 {
-                    Host = "41.223.25.5",
-                    Username = "anonymous",
-                    Password = "andrew@"
+                    Host = ftpOptions.Host,
+                    Username = ftpOptions.Username,
+                    Password = ftpOptions.Password
                 }))
                 {
                     await ftp.LoginAsync().ConfigureAwait(false);

BulkPrintingAPI/Startup.cs

@@ -42,6 +42,8 @@ namespace BulkPrintingAPI
                 Configuration.GetSection("DataEncryption")));
             services.AddSingleton(new MAX.ClientFactory(
                 Configuration.GetSection("MAX")));
+            services.AddSingleton(new FTPOptions(
+                Configuration.GetSection("FTP")));
             services.AddDbContext<MAX.Models.MAXContext>(
                 options => options.UseSqlServer(
                     Configuration["Database:ConnectionString"],